Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unused Parameters #997

Merged
merged 2 commits into from Nov 29, 2022
Merged

Removing unused Parameters #997

merged 2 commits into from Nov 29, 2022

Conversation

john-science
Copy link
Member

@john-science john-science commented Nov 28, 2022 •
edited

Description

I have done extensive testing on all the downstream repos I have access to.

And removing these 16 parameters changed nothing. I believe they are all unused and defunct.

This PR removes the parameters:

  • assemPeakStd
  • cladDensity
  • cladWorthDollarsPerKg
  • coolantWorthDollarsPerKg
  • corePow
  • coupledIteration
  • detailedDpaNewCycle
  • detailedDpaPeakNewCycle
  • directPertKeff
  • dpaRx
  • fuelRadialDisplacement
  • fuelWorthDollarsPerKg
  • hydDiam
  • innerMatrixIndex
  • regName
  • structureDensity
  • structureWorth
  • structureWorthDollarsPerKg

Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Nov 28, 2022
opotowsky
opotowsky requested changes Nov 28, 2022
View reviewed changes
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rateBalance is used downstream, but otherwise this looks good!

keckler
keckler approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@keckler keckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about dpaRx, but regardless, if kept, its description needs to be updated.

@john-science john-science merged commit 86f3716 into main Nov 29, 2022
@john-science john-science deleted the test_rm_params branch November 29, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opotowsky opotowsky opotowsky approved these changes

@keckler keckler keckler approved these changes

Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@john-science @opotowsky @keckler