-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Terrarium - Providers]: Implementation of Storage Feature - 3 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcharre
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few minor comments, looking good
Co-authored-by: Adam Charrett <73886859+adcharre@users.noreply.github.com>
Co-authored-by: Adam Charrett <73886859+adcharre@users.noreply.github.com>
This reverts commit 65c52bc.
This reverts commit ca2601f.
This reverts commit 71911b8.
This reverts commit 7501142.
This reverts commit 26b635f.
This reverts commit 1281216.
This reverts commit 2a7a675.
adcharre
approved these changes
Apr 30, 2024
anjanikshree12
added a commit
that referenced
this pull request
Apr 30, 2024
* implementation of consumer service * update in functions as we remove consumer service * go fmt * Update internal/provider/services/storage/storage.go Co-authored-by: Adam Charrett <73886859+adcharre@users.noreply.github.com> * updated storage.go * enhance error logs * updated storage_test * fix * fix * updated storage_test and mock server * [Terrarium - Providers]: Implementation of Storage Feature - 3 (#72) --------- Co-authored-by: Anjani Kumar Srivastava <anjani@anjanivm.com> Co-authored-by: Adam Charrett <73886859+adcharre@users.noreply.github.com>
anjanikshree12
added a commit
that referenced
this pull request
Apr 30, 2024
* protobuff definitions for consumer service * updated gen_proto.sh * removed ConsumerService as not required * format * [Terrarium - Providers]: Implementation of Storage Feature - 2 (#71) * implementation of consumer service * update in functions as we remove consumer service * go fmt * Update internal/provider/services/storage/storage.go Co-authored-by: Adam Charrett <73886859+adcharre@users.noreply.github.com> * updated storage.go * enhance error logs * updated storage_test * fix * fix * updated storage_test and mock server * [Terrarium - Providers]: Implementation of Storage Feature - 3 (#72) --------- Co-authored-by: Anjani Kumar Srivastava <anjani@anjanivm.com> Co-authored-by: Adam Charrett <73886859+adcharre@users.noreply.github.com> --------- Co-authored-by: Anjani Kumar Srivastava <anjani@anjanivm.com> Co-authored-by: Adam Charrett <73886859+adcharre@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR to #71
This PR includes:
Description:
S3 Directory tree structure to be followed.
Note: Shasum file and signature is common for each version, so getting stored at version level.