This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
Missing Parameter Type Error #48
Merged
terrencepreilly
merged 7 commits into
terrencepreilly:develop
from
FlorisHoogenboom:no-type-error
Oct 28, 2019
Merged
Missing Parameter Type Error #48
terrencepreilly
merged 7 commits into
terrencepreilly:develop
from
FlorisHoogenboom:no-type-error
Oct 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4870ada
to
a62bbe5
Compare
terrencepreilly
suggested changes
Oct 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good so far. Just a little cleaning up, and updating in light of the assumption that this error will be disabled by default.
@terrencepreilly I've added some code that would allow for disabeling some exceptions (including this one) by default and having the flake8 way of enabeling them via configuration like you mentioned in #49. Let me know what you think. If you want I can also make that last change into a seperate PR. |
terrencepreilly
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for the feature!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
DAR104 - The docstring parameter has no type specified
validation. This validation check if a docstring contains a type specification for each parameter and if none is present raises. Please see issue #49 for further background.