Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Missing Parameter Type Error #48

Merged

Conversation

FlorisHoogenboom
Copy link
Contributor

@FlorisHoogenboom FlorisHoogenboom commented Oct 24, 2019

This PR introduces DAR104 - The docstring parameter has no type specified validation. This validation check if a docstring contains a type specification for each parameter and if none is present raises. Please see issue #49 for further background.

Copy link
Owner

@terrencepreilly terrencepreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good so far. Just a little cleaning up, and updating in light of the assumption that this error will be disabled by default.

darglint/errors.py Outdated Show resolved Hide resolved
tests/test_error.py Outdated Show resolved Hide resolved
@FlorisHoogenboom
Copy link
Contributor Author

FlorisHoogenboom commented Oct 28, 2019

@terrencepreilly I've added some code that would allow for disabeling some exceptions (including this one) by default and having the flake8 way of enabeling them via configuration like you mentioned in #49. Let me know what you think. If you want I can also make that last change into a seperate PR.

@terrencepreilly terrencepreilly changed the base branch from master to develop October 28, 2019 14:57
Copy link
Owner

@terrencepreilly terrencepreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for the feature!

@terrencepreilly terrencepreilly merged commit 6017b65 into terrencepreilly:develop Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants