Support sources with URLs containing parameters

[marcjansen]

Follow up of #19, see #19 (comment)

Please review.

[weskamm]

Nice addition!
So URLs ending with a ? will get an & appended, right?
https://ows.terrestris.de/osm/service?&SERVICE=WMS.....
As far as i know, this should not be a problem, but not 100% sure.
Feel free to merge anyways!

[annarieger]

LGTM, thanks for fixing 🍍

[marcjansen]

So URLs ending with a ? will get an & appended, right?
https://ows.terrestris.de/osm/service?&SERVICE=WMS.....

Yes.

As far as i know, this should not be a problem, but not 100% sure.

Same here, I never experienced any bad behavior. If so we can always become smarter, I guess.

Thanks for the reviews.

[marcjansen]

How is this backported now?

[weskamm]

you can do it by checking out the ol4 branch, apply the patch and commit against ol4 branch.
Its up to you if you want to do it as we may remove that branch in the future anyways

[marcjansen]

I won't be able to do that and would love to have someone else take this duty from me, 😉