Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updateVectorLayer function #1089

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Fix updateVectorLayer function #1089

merged 4 commits into from
Mar 30, 2023

Conversation

hblitza
Copy link
Contributor

@hblitza hblitza commented Mar 3, 2023

Description

  • The updateVectorLayer function did not makes sense for timelayers, since we have no paging here, so I excluded them.
  • Plus, there should be no need to remove and add features to the hoversource, since they are already in it. The hoverStyleFunction in FeatureInfo handles the styling, also for selected features.
  • Fix several react hooks, use useCallback hook

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I have added a screenshot/screencast to illustrate the visual output of my update.
  • I have added the proposed change to the CHANGELOG.md.
  • I have run the test suite successfully (run npm test locally).

@hblitza hblitza marked this pull request as ready for review March 3, 2023 14:06
@hblitza hblitza merged commit 4ddb6ad into master Mar 30, 2023
@hblitza hblitza deleted the fix-update-hovervectorlayer branch March 30, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants