Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSIButton refactoring #817

Merged
merged 4 commits into from
May 19, 2021
Merged

HSIButton refactoring #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92bba8a
refactor hsi button to functional component
annarieger May 18, 2021
1bce147
remove obsolete t prop
annarieger May 18, 2021
404d389
add callback function called on button toggle
annarieger May 18, 2021
1ea3cf5
update changelog with #817
annarieger May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Breaking changes

- GetFeatureInfo components refactoring ([#810](https://github.com/terrestris/react-geo-baseclient/pull/811))
- `GetFeatureInfo` components refactoring ([#810](https://github.com/terrestris/react-geo-baseclient/pull/811))
- Refactored all `GetFeatureInfo` related components to react's functional component
- 🚨 Replaced `width` property set on GetFeatureInfo overlay menu by `maxWidth` (increased from 200 to 350px) to prevent cropped titles on long layer names
- Introduce "Zoom to layer resolution" context menu entry ([#809](https://github.com/terrestris/react-geo-baseclient/pull/809))
- `HSIButton` component refactoring ([#817](https://github.com/terrestris/react-geo-baseclient/pull/817))
- 🚨 `t` was removed from class props
- 🚨 `dispatch` was removed from class props, react-redux hook will be used instead
- 🚨 default value for `tooltip` is set to `Feature Info`
- 🚨 default value for `tooltipPlacement` is set to `right`
- added additional optional propery `onToggleCb` enabling custom logic on HSIButton activation (e.g. show notification about tool state, queryable layers etc.)
- Introduce `"Zoom to layer resolution"` context menu entry ([#809](https://github.com/terrestris/react-geo-baseclient/pull/809))
- Add configurable layer context menu entry "Zoom to layer resolution" (default is false)
- 🚨 Default value of `showZoomToLayerExtent` and `showApplyTimeInterval` configs was changed to `false`. So from now, the configs must be explicitily provided by component instantiation if the context menu entries should be shown in client.

Expand Down
Loading