Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diverse permalink fixes #818

Merged
merged 4 commits into from
May 20, 2021
Merged

Diverse permalink fixes #818

merged 4 commits into from
May 20, 2021

Conversation

annarieger
Copy link
Member

@annarieger annarieger commented May 19, 2021 •
edited
Loading

Description

  • Fixes call of default getLink function (coming from PermalinkUtil.getLink method of ol-util)
  • Ensures that permalink will be applied only once on first render

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I have added a screenshot/screencast to illustrate the visual output of my update.
  • I have added the proposed change to the CHANGELOG.md.
  • I have run the test suite successfully (run npm test locally).

@annarieger annarieger merged commit e28e261 into master May 20, 2021
@annarieger annarieger deleted the fix-permalink branch May 20, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weskamm weskamm weskamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@annarieger @weskamm