[Windows] Change save directory to application temp directory #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…native-sketch-canvas into jamecbernardo-windowscpp
Windows works with Device Independent Pixels already. Don't apply screen scale in JavaScript, as is the case for iOS.
windows: add example and tests
…handle windows: fix image file handle being kept open
Fixes transferToBase64 thread affinity for compatibility with react-native-windows >= 0.64.
Modernizes the code to use UIManager.getViewManagerConfig, since the old method of accessing the module's Constants and Commands is being deprecated.
…ead-affinity windows: fix transferToBase64 thread affinity (react-native-windows 0.64)
…-dpis windows: fix saved image on different screen scales
…ctory of the application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had multiple clients that were unable to save to the PicturesLibrary in Windows even though permission was granted.
That could usually be solved by reinstalling windows, on a fresh install it always worked but that is not a feasible solution for our clients.
Instead I created a PR here which changes the directory to save to from the PicturesLibrary to the TemporaryDirectory of the application.
iOS also uses the TemporaryDirectory to save to while in Android it uses the ExternalStoragePicturesDirectory.