- IRMethod>>#removeReturn is dead code

- IRPushClosureCopy ivar "lastBlockSequence" is set but never used (and not documented) - #lookUpSelector:, possibleSelectorFor: and #lookUpGlobalVar: on semantic scope are not needed - formatting of #hasTemporaryVariableNamed: (remove () )
tesonep · Oct 9, 2019 · 2874871 · 2874871
1 parent 848f6f5
commit 2874871
Show file tree

Hide file tree

Showing 8 changed files with 3 additions and 43 deletions.
diff --git a/src/OpalCompiler-Core/IRBuilder.class.st b/src/OpalCompiler-Core/IRBuilder.class.st
@@ -416,7 +416,6 @@ IRBuilder >> startNewSequence [
 
 	currentSequence last transitionsToNextSequence
 		ifFalse: [ self add: (IRJump new destination: newSequence)].
-	self currentScope isPushClosureCopy ifTrue: [self currentScope lastBlockSequence: currentSequence].
 	currentSequence := newSequence.
 
 ]

diff --git a/src/OpalCompiler-Core/IRMethod.class.st b/src/OpalCompiler-Core/IRMethod.class.st
@@ -339,11 +339,6 @@ IRMethod >> removeEmptyStart [
 
 ]
 
-{ #category : #inlining }
-IRMethod >> removeReturn [
-	self allSequences last removeLast.
-]
-
 { #category : #accessing }
 IRMethod >> sourceInterval [
 	^self sourceNode sourceInterval

diff --git a/src/OpalCompiler-Core/IRPushClosureCopy.class.st b/src/OpalCompiler-Core/IRPushClosureCopy.class.st
@@ -13,7 +13,6 @@ Class {
 		'blockSequence',
 		'tempMap',
 		'copiedValues',
-		'lastBlockSequence',
 		'arguments'
 	],
 	#category : #'OpalCompiler-Core-IR-Nodes'
@@ -88,16 +87,6 @@ IRPushClosureCopy >> isPushClosureCopy [
 	^true
 ]
 
-{ #category : #accessing }
-IRPushClosureCopy >> lastBlockSequence [ 
-	^lastBlockSequence
-]
-
-{ #category : #accessing }
-IRPushClosureCopy >> lastBlockSequence: aSequence [
-	lastBlockSequence := aSequence
-]
-
 { #category : #accessing }
 IRPushClosureCopy >> nonBodySuccessorSequences [
 

diff --git a/src/OpalCompiler-Core/OCAbstractScope.class.st b/src/OpalCompiler-Core/OCAbstractScope.class.st
@@ -55,13 +55,6 @@ OCAbstractScope >> isMethodScope [
 	^false
 ]
 
-{ #category : #lookup }
-OCAbstractScope >> lookupSelector: name [
-
-	Symbol hasInterned: name ifTrue: [ :sym | ^ sym].
-	^ nil
-]
-
 { #category : #lookup }
 OCAbstractScope >> lookupVar: name [
 	"search the scope (and the outer scopes) for a variable 'name' and return it"
@@ -100,12 +93,6 @@ OCAbstractScope >> outerScope: aSemScope [
 	aSemScope addChild: self. 
 ]
 
-{ #category : #lookup }
-OCAbstractScope >> possibleSelectorsFor: string [
-
-	^ Symbol possibleSelectorsFor: string
-]
-
 { #category : #levels }
 OCAbstractScope >> scopeLevel [
 

diff --git a/src/OpalCompiler-Core/OCRequestorScope.class.st b/src/OpalCompiler-Core/OCRequestorScope.class.st
@@ -36,15 +36,6 @@ OCRequestorScope >> findVariable: aBlock ifNone: aNotFound [
 		^  outerScope findVariable: aBlock ifNone: aNotFound ]
 ]
 
-{ #category : #lookup }
-OCRequestorScope >> lookupGlobalVar: aName [
-	"consider variables with upper case as global vars resolveable in the outer scope "
-
-	^ aName first isUppercase
-		ifTrue: [ outerScope lookupVar: aName ]
-		ifFalse: [ nil ]
-]
-
 { #category : #lookup }
 OCRequestorScope >> lookupVar: name [
 

diff --git a/src/Slot-Core/BlockClosure.extension.st b/src/Slot-Core/BlockClosure.extension.st
@@ -2,7 +2,7 @@ Extension { #name : #BlockClosure }
 
 { #category : #'*Slot-Core' }
 BlockClosure >> hasTemporaryVariableNamed: aName [
-	^(self tempNames includes: aName)
+	^self tempNames includes: aName
 ]
 
 { #category : #'*Slot-Core' }

diff --git a/src/Slot-Core/CompiledMethod.extension.st b/src/Slot-Core/CompiledMethod.extension.st
@@ -2,8 +2,7 @@ Extension { #name : #CompiledMethod }
 
 { #category : #'*Slot-Core' }
 CompiledMethod >> hasTemporaryVariableNamed: aName [
-	^(self tempNames includes: aName)
-
+	^ self tempNames includes: aName
 ]
 
 { #category : #'*Slot-Core' }

diff --git a/src/Slot-Core/Context.extension.st b/src/Slot-Core/Context.extension.st
@@ -2,5 +2,5 @@ Extension { #name : #Context }
 
 { #category : #'*Slot-Core' }
 Context >> hasTemporaryVariableNamed: aName [
-	^(self tempNames includes: aName)
+	^ self tempNames includes: aName
 ]