Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: CyrilFerlicot <cyril@ferlicot.me>
  • Loading branch information
mayonnaise-is-an-instrument and jecisc committed Oct 28, 2019
1 parent 5201cb9 commit b348495
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/Kernel/Boolean.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ Boolean >> ifFalse: alternativeBlock [
Boolean >> ifFalse: falseAlternativeBlock ifTrue: trueAlternativeBlock [
"Same as ifTrue:ifFalse:."

"true ifFalse: [ ^'That is false!' ] ifTrue: [ ^'That is true!' ] >>> 'That is true!'"
"true ifFalse: [ 'That is false!' ] ifTrue: [ 'That is true!' ] >>> 'That is true!'"
"false ifFalse: [ 'That is false!' ] ifTrue: [ 'That is true!' ] >>> 'That is false!'"

self subclassResponsibility
Expand All @@ -134,8 +134,8 @@ Boolean >> ifTrue: alternativeBlock [
receiver is nonBoolean. Execution does not actually reach here because
the expression is compiled in-line."

"true ifTrue: [^ 'This statement is true!'] >>> 'This statement is true!'"
"false ifTrue: [^ 'This statement is true!'] >>> nil"
"true ifTrue: [ 'This statement is true!' ] >>> 'This statement is true!'"
"false ifTrue: [ 'This statement is true!' ] >>> nil"

self subclassResponsibility
]
Expand All @@ -148,7 +148,7 @@ Boolean >> ifTrue: trueAlternativeBlock ifFalse: falseAlternativeBlock [
is a nonBoolean then create an error notification. Execution does not
actually reach here because the expression is compiled in-line."

"true ifTrue: [ ^'That is true!' ] ifFalse: [ ^'That is false!' ] >>> 'That is true!'"
"true ifTrue: [ 'That is true!' ] ifFalse: [ 'That is false!' ] >>> 'That is true!'"
"false ifTrue: [ 'That is true!' ] ifFalse: [ 'That is false!' ] >>> 'That is false!'"

self subclassResponsibility
Expand Down

0 comments on commit b348495

Please sign in to comment.