Cleanup Debugger-Filters package

Fix pharo-project#6667
tesonep · Jun 24, 2020 · c39e2e8 · c39e2e8
1 parent f1626bf
commit c39e2e8
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 13 deletions.
diff --git a/src/Debugger-Filters/BlockFilter.class.st b/src/Debugger-Filters/BlockFilter.class.st
@@ -7,7 +7,7 @@ Class {
 	#instVars : [
 		'block'
 	],
-	#category : #'Debugger-Filters'
+	#category : #'Debugger-Filters-Base'
 }
 
 { #category : #'instance creation' }

diff --git a/src/Debugger-Filters/BooleanFilter.class.st b/src/Debugger-Filters/BooleanFilter.class.st
@@ -8,7 +8,7 @@ Class {
 		'filters',
 		'booleanOperator'
 	],
-	#category : #'Debugger-Filters'
+	#category : #'Debugger-Filters-Base'
 }
 
 { #category : #'instance creation' }
@@ -40,5 +40,6 @@ BooleanFilter >> filters: theFilters [
 
 { #category : #testing }
 BooleanFilter >> shouldDisplay: aContext [
-	^ (self filters first shouldDisplay: aContext) perform: booleanOperator with: [self filters last shouldDisplay: aContext]  
+	^ (self filters first shouldDisplay: aContext) 
+			perform: booleanOperator with: [self filters last shouldDisplay: aContext]  
 ]
diff --git a/src/Debugger-Filters/KernelClassesFilter.class.st b/src/Debugger-Filters/KernelClassesFilter.class.st
@@ -7,7 +7,7 @@ Class {
 	#instVars : [
 		'kernelClasses'
 	],
-	#category : #'Debugger-Filters'
+	#category : #'Debugger-Filters-Base'
 }
 
 { #category : #initialization }

diff --git a/src/Debugger-Filters/ManifestDebuggerFilters.class.st b/src/Debugger-Filters/ManifestDebuggerFilters.class.st
@@ -0,0 +1,23 @@
+"
+I store metadata for this package. These meta data are used by other tools such as the SmalllintManifestChecker and the critics Browser
+"
+Class {
+	#name : #ManifestDebuggerFilters,
+	#superclass : #PackageManifest,
+	#category : #'Debugger-Filters-Manifest'
+}
+
+{ #category : #'code-critics' }
+ManifestDebuggerFilters class >> ruleBadMessageRule2V1FalsePositive [
+	^ #(#(#(#RGMethodDefinition #(#BooleanFilter #shouldDisplay: #false)) #'2020-06-24T08:38:44.359688+02:00') )
+]
+
+{ #category : #'code-critics' }
+ManifestDebuggerFilters class >> ruleCollectionMessagesToExternalObjectRuleV1FalsePositive [
+	^ #(#(#(#RGMetaclassDefinition #(#'SelectorFilter class' #SelectorFilter)) #'2020-06-24T08:39:44.785251+02:00') )
+]
+
+{ #category : #'code-critics' }
+ManifestDebuggerFilters class >> ruleUsesTrueRuleV1FalsePositive [
+	^ #(#(#(#RGMethodDefinition #(#KernelClassesFilter #kernelClassesToExclude #false)) #'2020-06-24T08:38:55.095241+02:00') )
+]
diff --git a/src/Debugger-Filters/SelectorFilter.class.st b/src/Debugger-Filters/SelectorFilter.class.st
@@ -7,22 +7,20 @@ Class {
 	#instVars : [
 		'selectors'
 	],
-	#category : #'Debugger-Filters'
+	#category : #'Debugger-Filters-Base'
 }
 
 { #category : #'instance creation' }
 SelectorFilter class >> forSelector: aSelector [
-	|filter|
-
+	|filter|	
 	filter:= self new.
 	filter selectors add: aSelector.
 	^ filter
 ]
 
 { #category : #'instance creation' }
 SelectorFilter class >> forSelectors: someSelectors [
-	 |filter|
-
+	 |filter|	
 	 filter:= self new.
 	 filter selectors addAll: someSelectors.
 	^ filter
@@ -31,7 +29,7 @@ SelectorFilter class >> forSelectors: someSelectors [
 { #category : #initialization }
 SelectorFilter >> initialize [
 	super initialize.
-	self selectors: OrderedCollection new.
+	self selectors: OrderedCollection new
 ]
 
 { #category : #accessing }
@@ -46,6 +44,5 @@ SelectorFilter >> selectors: someSelectors [
 
 { #category : #testing }
 SelectorFilter >> shouldDisplay: aContext [
-	 ^ (self selectors  
-		includes: aContext method selector) not.
+	 ^ (self selectors includes: aContext method selector) not
 ]
diff --git a/src/Debugger-Filters/StackFilter.class.st b/src/Debugger-Filters/StackFilter.class.st
@@ -4,9 +4,14 @@ A filter on the current stack for debugging
 Class {
 	#name : #StackFilter,
 	#superclass : #Object,
-	#category : #'Debugger-Filters'
+	#category : #'Debugger-Filters-Base'
 }
 
+{ #category : #testing }
+StackFilter class >> isAbstract [ 
+	 ^self == StackFilter
+]
+
 { #category : #operators }
 StackFilter >> and: aFilter [
 	  ^ BooleanFilter withFilters: (OrderedCollection with: self with: aFilter) operator: #and: