Detect id_rsa permissions problems and bail out early. Fixes gh-1219 (#…

…1222) * Detect id_rsa permissions problems and bail out early. Fixes gh-1219 Signed-off-by: Rick Waldron <waldron.rick@gmail.com> * fs.readFileSync => fs.accessSync Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
tessel · Jun 5, 2017 · 3a4280c · 3a4280c
1 parent 4692d0c
commit 3a4280c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/lib/controller.js b/lib/controller.js
@@ -1,6 +1,7 @@
 'use strict';
 
 // System Objects
+var fs = require('fs');
 var cp = require('child_process');
 var util = require('util');
 
@@ -30,6 +31,17 @@ var responses = {
   auth: 'No Tessels Found.'
 };
 
+// Alert the user that they have a permissions problem.
+try {
+  fs.accessSync(Tessel.LOCAL_AUTH_KEY, fs.constants.R_OK | fs.constants.W_OK);
+} catch (error) {
+  if (error.code === 'EACCES') {
+    log.error(`Permissions issue detected.`);
+    log.error(`Try using 'sudo t2 ${process.argv.slice(2).join(' ')}'`);
+    process.exit(1);
+  }
+}
+
 // Wrapper function for Tessel.list to set SSH key path
 controller.list = function(opts) {
   return controller.defaultHelpers(opts, Tessel.list);

diff --git a/lib/lan-connection.js b/lib/lan-connection.js
@@ -1,6 +1,5 @@
 // System Objects
 var events = require('events');
-var path = require('path');
 var util = require('util');
 
 var Emitter = events.EventEmitter;
@@ -48,7 +47,7 @@ LAN.Connection = function(opts) {
   this.ssh = undefined;
 
   if (Tessel.isProvisioned()) {
-    this.auth.privateKey = opts.privateKey || fs.readFileSync(path.join(Tessel.LOCAL_AUTH_KEY));
+    this.auth.privateKey = opts.privateKey || fs.readFileSync(Tessel.LOCAL_AUTH_KEY);
   }
 };