Detect id_rsa permissions problems and bail out early. Fixes gh-1219 #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaldron
requested review from
kwyn and
HipsterBrown
and removed request for
kwyn
kwyn
reviewed
Jun 1, 2017
| @@ -48,7 +47,7 @@ LAN.Connection = function(opts) { | |||
| this.ssh = undefined; | |||
|
|
|||
| if (Tessel.isProvisioned()) { | |||
| this.auth.privateKey = opts.privateKey || fs.readFileSync(path.join(Tessel.LOCAL_AUTH_KEY)); | |||
| this.auth.privateKey = opts.privateKey || fs.readFileSync(Tessel.LOCAL_AUTH_KEY); | |||
There was a problem hiding this comment.
Should we write a common module that reads the auth key and throws the EACCESS error even in this case?. Then we can use it in both lib/controller.js and here.
There was a problem hiding this comment.
If the permissions problem exists, no operation will ever reach this code.
HipsterBrown
approved these changes
Jun 2, 2017
LinusU
approved these changes
Jun 4, 2017
lib/controller.js
Outdated
| @@ -28,6 +29,17 @@ var responses = { | |||
| auth: 'No Tessels Found.' | |||
| }; | |||
|
|
|||
| // Alert the user that they have a permissions problem. | |||
| try { | |||
| fs.readFileSync(Tessel.LOCAL_AUTH_KEY); | |||
There was a problem hiding this comment.
Could probably be fs.accessSync which wouldn't read the file into memory
There was a problem hiding this comment.
Oh, good call. Let me try that
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rick Waldron waldron.rick@gmail.com