Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim build construction can fail silently if script has syntax error #441

Closed
johnnyman727 opened this issue Nov 14, 2015 · 0 comments
Closed
Assignees

Comments

@johnnyman727
Copy link
Contributor

My deploys were hanging after 'generating slim build'. I had a feeling that some rejection was not being handled properly so I put a few console.logs in the tarBundle function. It turns out this error was being rejected:

error on bundle... { [Error: Parsing file /Users/Jon/Work/technical/modules/ambient-attx4/examples/ambient.js: Unexpected token (16:5)]
  stream:
   Labeled {
     _readableState:
      ReadableState {
        highWaterMark: 16,
        buffer: [],
        length: 0,
        pipes: [Object],
        pipesCount: 1,
        flowing: true,
        ended: false,
        endEmitted: false,
        reading: true,
        sync: false,
        needReadable: true,
        emittedReadable: false,
        readableListening: false,
        objectMode: true,
        defaultEncoding: 'utf8',
        ranOut: false,
        awaitDrain: 0,
        readingMore: false,
        decoder: null,
        encoding: null,
        resumeScheduled: false },
     readable: true,
     domain: null,
     _events:
      { end: [Object],
        error: [Object],
        data: [Function: ondata],
        _mutate: [Object] },
     _eventsCount: 4,
     _maxListeners: undefined,
     _writableState:
      WritableState {
        highWaterMark: 16,
        objectMode: true,
        needDrain: false,
        ending: true,
        ended: true,
        finished: true,
        decodeStrings: true,
        defaultEncoding: 'utf8',
        length: 0,
        writing: false,
        corked: 0,
        sync: false,
        bufferProcessing: false,
        onwrite: [Function],
        writecb: null,
        writelen: 0,
        buffer: [],
        pendingcb: 0,
        prefinished: true,
        errorEmitted: false },
     writable: true,
     allowHalfOpen: true,
     _options: { objectMode: true },
     _wrapOptions: { objectMode: true },
     _streams: [ [Object] ],
     length: 1,
     label: 'deps' } }

This was caused because my script had a syntax error.

@johnnyman727 johnnyman727 changed the title Slim build construction can fail silently Slim build construction can fail silently if script has syntax error Nov 14, 2015
@rwaldron rwaldron self-assigned this Nov 15, 2015
rwaldron added a commit that referenced this issue Nov 17, 2015
Ensure that bundling errors make are surfaced. Fixes gh-441
rwaldron added a commit that referenced this issue Nov 17, 2015
# By Rick Waldron (9) and others
# Via Rick Waldron (7) and others
* 'master' of github.com:tessel/t2-cli: (21 commits)
  Add appveyor badge to readme
  Instead of rethrowing errors, log them. Fixes gh-449
  Fix jscs error: dont use future reserved words as identifiers
  Updating grunt-jscs
  fix(access-point): removes template literals cause jsbeautify
  Tweak status messages
  replaces new Errors with strings
  fix(access-point): creates boilerplate for new access point when required
  Adds check step to AP setup. Needs AP _new_ iface.
  fix(ap/wifi): working implementation
  refactor(access-point): simpler, cleaner tests and source code
  tests(access-point): initial implementation
  feat(access-point): adds ability to enable/disable AP
  fix: working access point configuration
  fix(ap): now able to configure ap setup
  feat(ap): initial access point creation implementation
  When single flag is present, do not traverse upward for package.json. Fixes gh-442
  Ensure that bundling errors make are surfaced. Fixes gh-441
  Adding linux driver install
  only set key if requested
  ...

Conflicts:
	lib/controller.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants