-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using new Error(...) in reject() #449
Comments
rwaldron
changed the title
Stop using new Error(...) in rejec()
Stop using new Error(...) in rejec()t
Nov 16, 2015
rwaldron
changed the title
Stop using new Error(...) in rejec()t
Stop using new Error(...) in reject()
Nov 16, 2015
Or should it just use |
Here's an example, where instead of rethrowing and doing absolutely nothing with it, t2 will log an error instead. Before:
After:
|
(note that was done on an older branch, I just needed something to demonstrate with) |
This blocks #444 |
rwaldron
added a commit
to rwaldron/t2-cli
that referenced
this issue
Nov 16, 2015
rwaldron
added a commit
to rwaldron/t2-cli
that referenced
this issue
Nov 16, 2015
rwaldron
added a commit
that referenced
this issue
Nov 17, 2015
Instead of rethrowing errors, log them. Fixes gh-449
rwaldron
added a commit
that referenced
this issue
Nov 17, 2015
# By Rick Waldron (9) and others # Via Rick Waldron (7) and others * 'master' of github.com:tessel/t2-cli: (21 commits) Add appveyor badge to readme Instead of rethrowing errors, log them. Fixes gh-449 Fix jscs error: dont use future reserved words as identifiers Updating grunt-jscs fix(access-point): removes template literals cause jsbeautify Tweak status messages replaces new Errors with strings fix(access-point): creates boilerplate for new access point when required Adds check step to AP setup. Needs AP _new_ iface. fix(ap/wifi): working implementation refactor(access-point): simpler, cleaner tests and source code tests(access-point): initial implementation feat(access-point): adds ability to enable/disable AP fix: working access point configuration fix(ap): now able to configure ap setup feat(ap): initial access point creation implementation When single flag is present, do not traverse upward for package.json. Fixes gh-442 Ensure that bundling errors make are surfaced. Fixes gh-441 Adding linux driver install only set key if requested ... Conflicts: lib/controller.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When
reject(new Error(...))
is called,closeFailedCommand
(in bin/tessel-2.js) does this:Which means this happens:
...Followed by the entire stack trace.
Passing a string will log the string as a warning.
The text was updated successfully, but these errors were encountered: