Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a command for fetching the current version of the CLI #604

Closed
johnnyman727 opened this issue Feb 25, 2016 · 4 comments · Fixed by #689
Closed

Make a command for fetching the current version of the CLI #604

johnnyman727 opened this issue Feb 25, 2016 · 4 comments · Fixed by #689

Comments

@johnnyman727
Copy link
Contributor

This is useful for debugging purposes.

The likely implementation will take the current t2-cli commit sha and either compare it to Github tags (where we save each version) or we'll save a copy of each version on our AWS server like we did with Tessel 1.

@wyze
Copy link
Member

wyze commented Apr 16, 2016

Couldn't this be as simple as just reading in the version field from package.json? I added the output really quick and could look something like this:

❯ t2 version
INFO Looking for your Tessel...
INFO Connected to t2-testing.
INFO Tessel [t2-testing] CLI version: 0.0.18
INFO Tessel [t2-testing] Firmware version: 0.0.12
INFO Tessel [t2-testing] Node version: 4.2.1

@johnnyman727
Copy link
Contributor Author

@wyze It's been a while now but what I think I meant was that we want a way to compare the version of the CLI being used with the most recently published (which I referred to as "current") CLI. In any case, that was closed with #665 but outputting the CLI version in the t2 version command would definitely still be useful.

@wyze
Copy link
Member

wyze commented Apr 18, 2016

Alright, that makes sense. I will send a PR over adding CLI version to output of t2 version and it can be discussed there further if the team would like it to be added or not. Thanks for the clarification.

@johnnyman727
Copy link
Contributor Author

👍

johnnyman727 added a commit that referenced this issue Apr 20, 2016
Add CLI version to `t2 version` command output (#604)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants