Tests do not complete on Node 5.x

[wyze]

It just stops in the deploy tests. Here is a snippet of the last few lines:

deploy.sendBundle, error handling - findProject...OK
deploy.sendBundle, error handling - resolveBinaryModules...OK
deploy.sendBundle, error handling - tarBundle...OK
deploy.resolveBinaryModules - bailOnSkipBinary...OK
deploy.resolveBinaryModules - findsModulesMissingBinaryNodeFiles...OK
deploy.resolveBinaryModules - spawnPythonScriptReturnsNull...OK
deploy.resolveBinaryModules - spawnPythonScript...OK
deploy.resolveBinaryModules - failsWithMessage...OK
deploy.resolveBinaryModules - existsInLocalCache...OK
deploy.resolveBinaryModules - existsInLocalCacheNodeGypLinkedBinPath...OK
deploy.resolveBinaryModules - resolveFromRealDirFixtures...OK
deploy.resolveBinaryModules - requestsRemote...

Full log here: https://gist.github.com/wyze/a1a07340cc97a9f3e151dbe9e5687eba

Happening on Travis as well: OSX | Linux

Possibly related to #695.

Looks like @rwaldron stumbled upon this here: #703 (comment)

[rwaldron]

I'm hitting this as well:

grunt test -v
# a bunch of stuff omitted
Testing access-point.js
Tessel.prototype.createAccessPoint - newAccessPoint...OK
Tessel.prototype.createAccessPoint - noPasswordNoSecurity...Segmentation fault: 11

[rwaldron]

Using segfault-handler, added to test/common/bootstrap.js, I've recorded the following:

$ grunt nodeunit:only:access-point
Running "nodeunit:only:access-point" (nodeunit:only) task

Running "nodeunit:tests" (nodeunit) task
ERR! WARNING: No usb controller found on this system.
Testing access-point.js.PID 21342 received SIGSEGV for address: 0x107f56bf8
0   segfault-handler.node               0x00000001023f9f08 _ZL16segfault_handleriP9__siginfoPv + 280
1   libsystem_platform.dylib            0x00007fff8c62e52a _sigtramp + 26
2   node                                0x0000000100652cc3 _ZN4node13RunMicrotasksERKN2v820FunctionCallbackInfoINS0_5ValueEEE + 0
3   node                                0x000000010065a9ef _ZN4node5StartEiPPc + 594
4   node                                0x0000000100001934 start + 52
5   ???                                 0x0000000000000003 0x0 + 3

To clarify, I don't think this is coming from something inside test/unit/access-point.js

[rwaldron]

Ok, I needed to completely rm -r node_modules, then npm install, now:

$ grunt nodeunit:only:access-point
Running "nodeunit:only:access-point" (nodeunit:only) task

Running "nodeunit:tests" (nodeunit) task
Testing access-point.js.........OK
>> 66 assertions passed (887ms)

Done, without errors.

And sure enough:

$ grunt nodeunit:only:deploy
Running "nodeunit:only:deploy" (nodeunit:only) task

Running "nodeunit:tests" (nodeunit) task
Testing deploy.js..................................................................rwaldron at nova in ~/clonez/t2-cli on node-5-test-failures*

With -v:

# most logging omitted
deploy.resolveBinaryModules - spawnPythonScript...OK
deploy.resolveBinaryModules - failsWithMessage...OK
deploy.resolveBinaryModules - existsInLocalCache...OK
deploy.resolveBinaryModules - existsInLocalCacheNodeGypLinkedBinPath...OK
deploy.resolveBinaryModules - resolveFromRealDirFixtures...OK
deploy.resolveBinaryModules - requestsRemote...rwaldron at nova in ~/clonez/t2-cli on node-5-test-failures*