Convert t2 install-drivers and t2 install-homedir to t2 install X. Fixes gh-1019
#1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HipsterBrown please review @tcr once this lands, please rebase #1014 and refactor the sdk installation portions of your branch to use the new |
…X`. Fixes tesselgh-1019 This will allow normalized CLI "install" or "remove" additions: - `t2 install-drivers` => `t2 install drivers` - `t2 install-homedir` => `t2 install homedir` And future additions: - `t2 install rust-sdk` - `t2 remove rust-sdk` Presently no "remove" command has been defined for `drivers` or `homedir` as it's unclear that those installables are subject to such operations. Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
|
Ran the tests locally and this works for me in every supported Node version. 👍 |
|
Citing this again: https://travis-ci.org/tessel/t2-cli/builds/165619948 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blocks #1014
This will allow normalized CLI "install" or "remove" additions:
t2 install-drivers=>t2 install driverst2 install-homedir=>t2 install homedirAnd future additions:
t2 install rust-sdkt2 remove rust-sdkPresently no "remove" command has been defined for
driversorhomediras it's unclear that those installables are subject to such operations.Signed-off-by: Rick Waldron waldron.rick@gmail.com