Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t2 run/push record an entry point for reuse by t2 restart. Fixes gh-675 #677

Merged
merged 1 commit into from
Apr 16, 2016

Conversation

rwaldron
Copy link
Contributor

Signed-off-by: Rick Waldron waldron.rick@gmail.com

@rwaldron
Copy link
Contributor Author

In addition to closely monitoring appveyor, I will also reality check this on my windows machine and report back shortly

@rwaldron
Copy link
Contributor Author

I've confirmed that Appveyor's "green" status is not a false positive:

Locally, all tests pass on my windows 10 machine, however I cannot deploy due to some other unknown issue (nothing deploys, all I see is a "No Tessels Found" message)

@rwaldron
Copy link
Contributor Author

rwaldron commented Apr 15, 2016

cc @HipsterBrown @tikurahul or @johnnyman727 for review

@HipsterBrown
Copy link
Contributor

Looks good to me. Is there a smoke test I can run through?

@rwaldron
Copy link
Contributor Author

@HipsterBrown sure:

  1. Complete t2 init
  2. t2 run index.js, let it run then kill it
  3. t2 restart

Expect: t2 restart should automatically restart from "index.js"

@tikurahul
Copy link
Contributor

LGTM

@rwaldron
Copy link
Contributor Author

@HipsterBrown
Copy link
Contributor

@rwaldron Ran through your smoke test with the following results:

nickhehr@Nicks-MacBook-Pro-2 tessel-test $ t2 run index.js
INFO Looking for your Tessel...
INFO Connected to tessel-router.
INFO Building project.
INFO Writing project to RAM on tessel-router (3.072 kB)...
INFO Deployed.
INFO Running index.js...
I'm blinking! (Press CTRL + C to stop)
^Cnickhehr@Nicks-MacBook-Pro-2 tessel-test $
nickhehr@Nicks-MacBook-Pro-2 tessel-test $ t2 restart
INFO Looking for your Tessel...
INFO Connected to tessel-router.
INFO Running undefined...
module.js:339
    throw err;
    ^

Error: Cannot find module '/tmp/remote-script/undefined'
    at Function.Module._resolveFilename (module.js:337:15)
    at Function.Module._load (module.js:287:25)
    at Function.Module.runMain (module.js:467:10)
    at startup (node.js:134:18)
    at node.js:961:3
nickhehr@Nicks-MacBook-Pro-2 tessel-test $

I haven't started debugging yet but I'll check it out tonight.

@rwaldron
Copy link
Contributor Author

@rwaldron
Copy link
Contributor Author

@HipsterBrown are you definitely using this branch?

@rwaldron
Copy link
Contributor Author

Ah! I hit it too. Ok, will keep working on this.

@rwaldron
Copy link
Contributor Author

@HipsterBrown ok, ready for review when it goes green

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
"USB": true,
"tags": true,
"request": true,
"util": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is just alphabetization 0_o

@HipsterBrown
Copy link
Contributor

Did the smoke test again after the update, with the following results:

Nicks-MacBook-Pro:tessel-test hipsterbrown$ t2 init
Initializing Tessel 2 Project...
Created package.json.
Created .tesselinclude.
Wrote "Hello World" to index.js
Nicks-MacBook-Pro:tessel-test hipsterbrown$ t2 list
INFO Searching for nearby Tessels...
    USB tessel-router
Nicks-MacBook-Pro:tessel-test hipsterbrown$ t2 run index.js
INFO Looking for your Tessel...
INFO Connected to tessel-router.
INFO Building project.
INFO Writing project to RAM on tessel-router (3.072 kB)...
INFO Deployed.
INFO Running index.js...
I'm blinking! (Press CTRL + C to stop)
^CNicks-MacBook-Pro:tessel-test hipsterbrown$ t2 restart
INFO Looking for your Tessel...
INFO Connected to tessel-router.
INFO Running index.js...
I'm blinking! (Press CTRL + C to stop)
^CNicks-MacBook-Pro:tessel-test hipsterbrown$

Success!!! 👍 LGTM

@rwaldron
Copy link
Contributor Author

Thank you kindly sir ❤️

@rwaldron rwaldron merged commit 5589828 into master Apr 16, 2016
@Frijol Frijol deleted the 675 branch May 12, 2016 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants