-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t2 run/push record an entry point for reuse by t2 restart. Fixes gh-675 #677
Conversation
In addition to closely monitoring appveyor, I will also reality check this on my windows machine and report back shortly |
cc @HipsterBrown @tikurahul or @johnnyman727 for review |
Looks good to me. Is there a smoke test I can run through? |
@HipsterBrown sure:
Expect: |
Fixes CR-0x4036d9b8 http://crash-reporter.tessel.io/crashes?fingerprint=0x4036d9b8 |
@rwaldron Ran through your smoke test with the following results:
I haven't started debugging yet but I'll check it out tonight. |
Fixes CR-0xdc0fd98 http://crash-reporter.tessel.io/crashes?fingerprint=-0xdc0fd98 |
@HipsterBrown are you definitely using this branch? |
Ah! I hit it too. Ok, will keep working on this. |
@HipsterBrown ok, ready for review when it goes green |
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
"USB": true, | ||
"tags": true, | ||
"request": true, | ||
"util": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this is just alphabetization 0_o
Did the smoke test again after the update, with the following results:
Success!!! 👍 LGTM |
Thank you kindly sir ❤️ |
Signed-off-by: Rick Waldron waldron.rick@gmail.com