Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow USB connections with t2 root command (#673) #692

Merged
merged 1 commit into from
Apr 19, 2016
Merged

Disallow USB connections with t2 root command (#673) #692

merged 1 commit into from
Apr 19, 2016

Conversation

wyze
Copy link
Member

@wyze wyze commented Apr 19, 2016

Fixes #673

This will hide the flags if someone runs t2 root --help but doesn't disable them completely. I saw at least 2 options here, either error out and don't attempt a connection, or force the use of LAN connection and give the user a warning. I chose the 2nd route as I think it is a better user experience. But I am up for discussions on it.

Current output:

❯ t2 root --usb
WARN You are trying to connect to Tessel via USB, but this command only works with Wifi.
WARN I will use Wifi to try and look for your Tessel.
INFO Looking for your Tessel...
INFO Connected to t2-testing.
INFO Starting SSH Session on Tessel. Type 'exit' at the prompt to end.

@rwaldron
Copy link
Contributor

LGTM

@HipsterBrown @tikurahul R?

@tikurahul
Copy link
Contributor

LGTM

@rwaldron rwaldron merged commit ef0a5e2 into tessel:master Apr 19, 2016
@wyze wyze deleted the disable-usb-for-root branch April 19, 2016 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants