Fixes https://github.com/tessel/t2-cli/issues/691 #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -99,7 +96,8 @@ CrashReporter.post = function(labels, report) { | |||
| if (json.error) { | |||
| reject(json.error); | |||
| } else { | |||
| resolve(); | |||
| var fingerprint = json.crash_report.fingerprint; | |||
| resolve(fingerprint); | |||
There was a problem hiding this comment.
resolve(json.crash_report.fingerprint);
|
@tikurahul since there only the one minor change needed, once you've committed that, you can merge this to master |
|
Sorry, just saw your comments now. Will fix, and merge when I get home :) |
Sometimes native crashes are swallwed by the Crash reporter. Hence the uncaught exception handler prints them, and the Crash reporter also returns the correct fingerprint, so the crash can be discovered.
tikurahul
force-pushed
the
show_fingerprint
branch
from
d2921be
to
97b33ce
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes remote node crashes are swallowed by the Crash reporter. Now the uncaught exception
handler prints them, and the Crash reporter also returns the correct
fingerprint, so thecrash can be discovered and reported.