t2 run: move JS-specific "post run" operation to a language specific definition #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaldron
force-pushed
the
deployment-postRun
branch
2 times, most recently
from
fd85356
to
62d6335
Compare
| @@ -60,5 +60,6 @@ exportables.preRun = function(tessel) { | |||
| }); | |||
| }; | |||
|
|
|||
| // exportables.postRun = function(tessel, remote) {}; | |||
There was a problem hiding this comment.
This is here as "pseudo documentation" until the language support API churn slows and we can start documenting properly
…definition. Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
rwaldron
force-pushed
the
deployment-postRun
branch
from
62d6335
to
c146d6c
Compare
| tessel.connection.exec( | ||
| commands[opts.lang.meta.extname].execute(Tessel.REMOTE_RUN_PATH, opts.resolvedEntryPoint), { | ||
| commands[lang.meta.extname].execute(Tessel.REMOTE_RUN_PATH, options.resolvedEntryPoint), { |
There was a problem hiding this comment.
This is just renaming, nothing interesting
|
LGTM, I think the API changes are as good as can be. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@johnnyman727 This should be reviewed and merged before any of the pending Rust support changes.
Signed-off-by: Rick Waldron waldron.rick@gmail.com