Rust deployment #790
Rust deployment #790
Conversation
|
LGTM |
1 similar comment
|
LGTM |
|
I took a look at the code and also ran it. diff --git i/lib/tessel/deployment/rust.js w/lib/tessel/deployment/rust.js
- var details = exportables.meta.checkConfiguration(opts.target);
+ var details = exportables.meta.checkConfiguration(opts.target, null, opts.resolvedEntryPoint);I know v6 might not be officially supported. But if that is the only thing holding it back, can it be added? |
| @@ -203,8 +203,13 @@ makeCommand('run') | |||
| default: false, | |||
| help: 'Deploy a project containing all files within, including those not used by the program, excluding any files matched by non-negated rules in .tesselignore and including any files matched by rules in .tesselinclude. Program is started from specified file.' | |||
| }) | |||
| .option('rustCC', { | |||
There was a problem hiding this comment.
I'd like to suggest making this rustcc, so it's easier for end users to type
There was a problem hiding this comment.
or possibly rust-cc? Unix command line options are almost always in kebab-case
There was a problem hiding this comment.
I'm good with rust-cc. That's a little more intuitive to me.
There was a problem hiding this comment.
¯_(ツ)_/¯
Unix command line options are almost always in kebab-case
When they are distinctly two words, yes... but "cc" is an abbreviation right? I'm assuming "cross compiler"? That's two words, so by this logic, you want "rust-c-c" which is just cruel.
There was a problem hiding this comment.
I'll go with rustcc because it's shortest and, let's be honest, most users are very unlikely to go through the trouble of setting up their own cross compilers. It's pretty much just a developer flag.
|
I've just landed #787, this will need to be rebased. |
|
Needs to be rebased. |
| @@ -1,3 +1,5 @@ | |||
| var javascript = require('../../lib/tessel/deployment/javascript'); | |||
There was a problem hiding this comment.
This object is already globally available in this file as deployment.js (same thing for deployment.rs and deployment.py)
johnnyman727
force-pushed
the
jon-rust-deploy-3
branch
3 times, most recently
from
abc5eef
to
dbd6663
Compare
johnnyman727
force-pushed
the
jon-rust-deploy-3
branch
from
dbd6663
to
d90f375
Compare
|
Cleaned up commits and addressed PR comments. I'm going to work on getting the cross compilation server deployed on digital ocean, add the permanent IP here, and then merge. |
|
Smoke test for anyone that wants to try this: Watch the LEDs blink to your heart's content. |
|
👏 |
|
Sweet! Awesome work Jon! 🤗 On Wed, Jul 13, 2016, 12:18 PM Jon notifications@github.com wrote:
|
No description provided.