run/push: support "subargs" for forwarding to remote process. Fixes gh-732

[rwaldron]

Uses the "subarg" syntax:

t2 run index.js [foo bar baz -a 1 -b 2 --named --key=value]

Will result in process.argv on the deployed program:

[ '/usr/bin/node',
  '/tmp/remote-script/index.js',
  'foo',
  'bar',
  'baz',
  '-a',
  '1',
  '-b',
  '2',
  '--named',
  '--key=value' ]

Smoke Test

(pull this branch locally)

1. Create a new project:
   mkdir t2-732 && cd t2-732 && t2 init; npm install minimist --save

2. Open the index.js just now and replace the contents with:

   var argv = require('minimist')(process.argv.slice(2));
   
   console.log(argv);

3. Run t2 run index.js [foo bar baz -a 1 -b 2 --named --key=value]

Deployment should look something like this:

$ t2 run index.js [foo bar baz -a 1 -b 2 --named --key=value]
INFO Looking for your Tessel...
INFO Connected to ash.
INFO Building project.
INFO Writing project to RAM on ash (9.728 kB)...
INFO Deployed.
INFO Running index.js...
{ _: [ 'foo', 'bar', 'baz' ],
  a: 1,
  b: 2,
  named: true,
  key: 'value' }

Signed-off-by: Rick Waldron waldron.rick@gmail.com

[rwaldron]

EDIT: I deleted the line note because I'm adding the content as a comment in the source

[rwaldron]

@ebruchez wdyt?

@HipsterBrown review?

[HipsterBrown]

This should pass without the subargs property as well, right?

[rwaldron]

No, because this test runs code that exists at a point in which all default properties are resolved, so the subargs property will always be present, either empty or with contents

[HipsterBrown]

Code looks good to me. I can't do a smoke test tonight. I can do a smoke test tonight. Typo before.

A few questions:

• Would you suggest using subargs to pass through things like API tokens instead of environment variables?
• Could we also pass through environment variables in a similar way?

[HipsterBrown]

Smoke test results:

Nicks-MacBook-Pro:tessel-test hipsterbrown$ mkdir t2-732 && cd t2-732 && t2 init; npm install minimist --save
INFO Initializing new Tessel project for JavaScript...
INFO Created package.json.
INFO Created .tesselinclude.
INFO Wrote "Hello World" to index.js
minimist@1.2.0 node_modules/minimist
Nicks-MacBook-Pro:t2-732 hipsterbrown$ vim index.js
Nicks-MacBook-Pro:t2-732 hipsterbrown$ t2 run index.js [foo bar baz -a 1 -b 2 --named --key=value]
INFO Looking for your Tessel...
INFO Which Tessel do want to use?   LAN tessel-router
INFO Connected to tessel-router.
INFO Building project.
INFO Writing project to RAM on tessel-router (9.728 kB)...
INFO Deployed.
INFO Running index.js...
{ _: [ 'foo', 'bar', 'baz' ],
  a: 1,
  b: 2,
  named: true,
  key: 'value' }
Nicks-MacBook-Pro:t2-732 hipsterbrown$

Looks like a successful test! 👍

[rwaldron]

Could we also pass through environment variables in a similar way?

TBH, I'm not sure and this is an interesting question. I will do some tests and report back

[rwaldron]

Could we also pass through environment variables in a similar way?

I've spent some time with this question and have determined that this patch is not an appropriate mechanism to shoe-horn other features into. I'm going to stop at "just subargs" here.

[HipsterBrown]

@rwaldron Sounds good. I appreciate you taking the time to investigate that concept. LGTM 👍