Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reboots tessel after restore #983

Merged
merged 3 commits into from
Sep 21, 2016
Merged

reboots tessel after restore #983

merged 3 commits into from
Sep 21, 2016

Conversation

dbuentello
Copy link
Contributor

fixes #964

@dbuentello
Copy link
Contributor Author

This fails testing. I think it has to do with test setup...

Testing restore.jsERR! Detected CLI crash TypeError: Cannot read property 'controlTransfer' of undefined
ERR!     at exportables.enableWrite.then.then.then.then.then (/Users/dbuentello/_repos/Github/dbuentello/t2-cli/lib/tessel/restore.js:255:19)
ERR!     at process._tickCallback (internal/process/next_tick.js:103:7) TypeError: Cannot read property 'controlTransfer' of undefined
ERR!     at exportables.enableWrite.then.then.then.then.then (/Users/dbuentello/_repos/Github/dbuentello/t2-cli/lib/tessel/restore.js:255:19)
ERR!     at process._tickCallback (internal/process/next_tick.js:103:7)

Should I rewrite test or move code somewhere else?

@rwaldron
Copy link
Contributor

No, please do not rewrite/remove any tests. I will make a PR to your branch that adds a mock and a simple test to the existing tests. Once you merge it, you'll be able to pass the tests and then add more tests (based on the example I set forth)

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
(cherry picked from commit 1630e45)
@rwaldron
Copy link
Contributor

Ready for you to merge: dbuentello#1

t2 restore: stub for controlTransfer
@rwaldron
Copy link
Contributor

Nice! That was fast. Ok, so I left you a comment in this section: https://github.com/tessel/t2-cli/pull/983/files#diff-10458d609c4258a1a5a558303f4b58c1R448 which should give you an idea of what needs to be tested. Please let me know if you need any further guidance there—I'm here to help :)

@rwaldron rwaldron merged commit d11730d into tessel:master Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

t2 restore should automatically reboot tessel
2 participants