Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orocos_kdl dependency #848

Closed
rjoomen opened this issue Feb 22, 2023 · 4 comments · Fixed by #850
Closed

orocos_kdl dependency #848

rjoomen opened this issue Feb 22, 2023 · 4 comments · Fixed by #850

Comments

@rjoomen
Copy link
Contributor

rjoomen commented Feb 22, 2023

tesseract_kinematics, tesseract_scene_graph, and tesseract_state_solver have the following dependency on orocos_kdl:

  <depend condition="$ROS_DISTRO != noetic">orocos_kdl</depend>
  <depend condition="$ROS_DISTRO == noetic">liborocos-kdl-dev</depend>

I believe this is outdated, as all newer ROS versions use liborocos-kdl-dev. Or if supporting the old dependency is still desired, we should use some code like >= noetic, if possible.

@rjoomen
Copy link
Contributor Author

rjoomen commented Feb 22, 2023

Reason I'm asking is that all CI workflows have orocos_kdl in ROSDEP_SKIP_KEYS, which could be removed if this dependency is fixed.

@Levi-Armstrong
Copy link
Contributor

Currently the oldest version supported is noetic. I would what ever support noetic and newer versions.

@rjoomen
Copy link
Contributor Author

rjoomen commented Feb 22, 2023

Ugh, Humble has orocos_kdl_vendor, Foxy has orocos_kdl, Noetic has nothing, and Melodic has orocos_kdl again. And liborocos-kdl-dev is an Ubuntu package, not ROS, but at least that's been available since Bionic. I'll create a PR with liborocos-kdl-dev, or do we also have to support Windows?

@Levi-Armstrong
Copy link
Contributor

We do need to support windows, but I believe this should not impact the windows CI build if you make the proposed change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants