Allow nic name to be passed in as a parameter #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated azurerm.rb to include passing in a varibale for the name of the nic and also using that name or generating a nic name based on the vm name - Updated internal.erb to include nic name updates and also disk names that are unique based on vm name
stuartpreston
suggested changes
Sep 29, 2019
There was a problem hiding this comment.
Thank you very much for this contribution - happy to get this merged, but please could you rebase without the updated gemspec? (I will update the version at release time). Also would you be able to add a line into the readme to make note of this new parameter. Thanks again @aaronspiller
stuartpreston
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also using that name or generating a nic name based on the vm name
are unique based on vm name
Description
In our environment we have to use a predefined resource group with a specific subscription, and are not able to create a new resource group for each VM provisioned. As a result we can only create on VM at a time since the name "nic" is hardcoded and in use once a VM is provisioned.
This pull request is to allow for the nic name to be passed in as a parameter, or at least be unique based on the name of the VM if it is passed in. Testing in our site has dramatically improved our ability to have multiple nodes running at the same time.
I haven't cracked the nut of a destroy only destroying what it creates, but this is a big improvement
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List