Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DigitalOcean updated some images so the IDs required fixing. #9

Merged
2 commits merged into from
Apr 13, 2014

Conversation

juliandunn
Copy link

This was most likely done to remediate the Heartbleed SSL vulnerability.

https://www.digitalocean.com/company/blog/heartbleed-vulnerability-update/

@sethvargo
Copy link

@juliandunn looks like some of the specs are failing

@juliandunn
Copy link
Author

Should be ok now. Mea culpa; I should have run the tests instead of assuming this was just data.

@sethvargo
Copy link

👍

@ghost
Copy link

ghost commented Apr 12, 2014

I have a update I'm sitting on that does away with the data.json entirely and uses fuzzy matching. I'll push it to a branch later tonight and ping you guys and have a look before making it a release.

If you guys prefer to do release with this fix in the mean time let me know.

@ghost
Copy link

ghost commented Apr 13, 2014

Changed my mind, running out of time tonight, and this should get fixed. Going to merge this, cut a release.

I'll cut a new release with the fuzzy matching later in the week, I'm not happy with my code right now.

@ghost ghost closed this Apr 13, 2014
@ghost ghost reopened this Apr 13, 2014
ghost pushed a commit that referenced this pull request Apr 13, 2014
DigitalOcean updated some images so the IDs required fixing.
@ghost ghost merged commit e5007d6 into test-kitchen:master Apr 13, 2014
@juliandunn juliandunn deleted the fix-image-ids branch April 13, 2014 03:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants