Providing logger to instance_generator, fixes #142 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -159,6 +159,8 @@ def finalize_config!(instance) | |||
|
|
|||
| if config[:availability_zone].nil? | |||
| config[:availability_zone] = config[:region] + "b" | |||
| elsif config[:availability_zone] =~ /^[a-zA-Z]$/ | |||
There was a problem hiding this comment.
Not at all, it just brings the behavior in line with what was already in the README
|
+1, looks good if Travis is happy |
|
@tyler-ball Thank you for quick response, you are saving my day. |
tyler-ball
changed the title
|
Awesome! 👍 |
|
@tyler-ball THANK YOU:) 👍 |
tyler-ball
added a commit
that referenced
this pull request
Jun 3, 2015
Providing logger to instance_generator, fixes #142
|
0.9.4 released |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #142
Also brought the
availability_zonebehavior in line with the README\cc @joelhandwell @fnichol @metadave @randomcamel