Adding better retry logic to creation, fixes #179 (hopefully) #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| server.create_tags(:tags => tags) | ||
| # Unfortunately the AWS SDK doesn't actually wait correctly for instance existence, so we | ||
| # need to retry if they throw a `server with id doesn't exist` error | ||
| Retryable.retryable(:tries => 10, :sleep => lambda { |n| [2**n, 10].min }) do |retries, _| |
There was a problem hiding this comment.
maybe bump this to 30 seconds max
|
also, 💯 |
|
Here's the promised stacktrace |
|
This is the call to |
|
I don't even |
tyler-ball
force-pushed
the
tball/retry_correctly
branch
from
36768d9
to
b24b3ab
Compare
|
you should throw tag server in there as well. |
|
I hate throwing |
tyler-ball
force-pushed
the
tball/retry_correctly
branch
from
b24b3ab
to
ab5a8f2
Compare
|
didn't work :( |
|
|
This was referenced Jul 31, 2015
tyler-ball
force-pushed
the
tball/retry_correctly
branch
from
4caa5c8
to
0533c7f
Compare
tyler-ball
added a commit
that referenced
this pull request
Aug 3, 2015
Adding better retry logic to creation, fixes #179 (hopefully)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS Waiters still appear to be not correctly waiting for existence (see aws/aws-sdk-ruby#859). So adding better retry logic and outputting.
\cc @jaym @fnichol
Fixes #179
Rolls back #171 because that waited too long to provide output