New block_device_mappings config
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay tests have been added - this is ready for review! |
fnichol
added a commit
that referenced
this pull request
Feb 18, 2015
New `block_device_mappings` config
This was referenced Feb 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rolls a bunch of existing, storage based PRs into one:
I am deprecating the old, individual storage config keys and adding a new one which accepts a list. This allows users to specify multiple block device mappings. If one of the entries has the same name as the image root storage device it will be overridden.
To support backwards compatiability if you do not use the new
block_device_mappingsconfig it will be auto created using the old deprecated configs. It emits a warning because we will eventually remove this functionality.How are the READMEs? What do you think about usability?
\cc @fnichol @rvalyi @victorlin @nsdavidson @duggan