Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut new gem version with Preemptible support #29

Closed
Temikus opened this issue Jan 8, 2016 · 21 comments
Closed

Cut new gem version with Preemptible support #29

Temikus opened this issue Jan 8, 2016 · 21 comments

Comments

@Temikus
Copy link
Contributor

Temikus commented Jan 8, 2016

@marcy-terui asked when the new version is going to be released in #22
Since I'm not in the gem owners, summoning the owners: @anl , @tyler-ball , @someara

Hi Andrew, Sean, Tyler,

Can a new gem release be cut so we have preemptible support?
What are the conditions that need to be met before the release (if any)?

Thanks!

P.S. While we're at it - maybe it makes sense to rename the gem to kitchen-google for consistency sake?

@Temikus
Copy link
Contributor Author

Temikus commented Jan 8, 2016

@marcy-terui
Copy link

@Temikus Thank you for your quick reply!

Hello @someara, @tyler-ball,

Please release #22 if you have a time.
I'm not in a hurry.
But, I might make a different implementation if it's too delayed.
Because I want to add(change) some features later.

Thanks.

@marcy-terui
Copy link

Any updates? @someara @tyler-ball

@tyler-ball
Copy link

I'm going to ping @cheeseplus - he has been doing all the Test Kitchen maintenance recently

@someara
Copy link
Contributor

someara commented Jan 19, 2016

It doesn't look like there's a kitchen-google release on Rubygems at all,
actually.

Let's use this thread to sort out everyone who should have commit and
release bits.

What are everyone's Github and Rubygems account names?

-s

On Tue, Jan 19, 2016 at 1:21 PM, Tyler Ball notifications@github.com
wrote:

I'm going to ping @cheeseplus https://github.com/cheeseplus - he has
been doing all the Test Kitchen maintenance recently


Reply to this email directly or view it on GitHub
#29 (comment)
.

@Temikus
Copy link
Contributor Author

Temikus commented Jan 20, 2016

The current gem is published under Kitchen-GCE:
https://rubygems.org/gems/kitchen-gce

I don't know why exactly it's not kitchen-google, but @erjohnso and @mbrukman may give some more context on that. If there's no particular reason or it's no longer relevant I strongly vote for the gem name to mimic the name of the repo to avoid confusion, e.g. kitchen-google

My rubygems account, github is the same - temikus:
https://rubygems.org/profiles/temikus

@marcy-terui
Copy link

@tyler-ball @someara Thanks for your reply.

I agree with @Temikus about the name of gem and repo.

My account name in GitHub and RubyGems is the same - marcy-terui
https://rubygems.org/profiles/marcy-terui

@erjohnso
Copy link

This was the old issue to move Andrew's project over to Test Kitchen. I think we'd all prefer to see the gem match the repo.

Perhaps we can just make a new gem called kitchen-google? Seems that the kitchen-gce gem still points to Andrew's old/defunct repo.

My account is: https://rubygems.org/profiles/erjohnso

@anl
Copy link
Contributor

anl commented Jan 20, 2016

Is there anything I can do to help here?

@erjohnso
Copy link

Hi @anl!

Perhaps. Is it possible to rename the rubygem, update the metadata, and add some backup humans to roll new releases? Alternatively, I think we could spin up a new gem and then delete the defunct kitchen-gce gem.

wdyt?

@Temikus
Copy link
Contributor Author

Temikus commented Jan 20, 2016

If I may add one suggestion - if we go the route of "spin up a new gem and delete the old gem", can we push a version bump of the old gem with a deprecation notifier, so people at least know what to switch to?

For example, at least add a post_install_message to the gemspec:

gem.post_install_message = <<-MESSAGE
!    The 'kitchen-gce' gem has been deprecated and has been replaced by 'kitchen-google'.
!    See: https://rubygems.org/gems/kitchen-google
!    And: https://github.com/test-kitchen/kitchen-google
MESSAGE

@anl
Copy link
Contributor

anl commented Jan 22, 2016

@erjohnso @Temikus My schedule is full today (and I can't do test-kitchen work at $DAYJOB) but I will tackle this tomorrow. Agreed that a deprecation notifier is a good way to go.

@Temikus
Copy link
Contributor Author

Temikus commented Jan 22, 2016

@anl Thank you very much! If you need any help - let me know, I'd be happy to!

@marcy-terui
Copy link

@anl That would be great 👍 Thank you very much 😄 !

@mbrukman
Copy link
Contributor

My account is also the same as on GitHub: https://rubygems.org/profiles/mbrukman

@anl
Copy link
Contributor

anl commented Jan 24, 2016

I've released kitchen-google v0.3.0 on Rubygems; @mbrukman, I made you an owner for that gem and kitchen-gce also.

I have not yet added a deprecation notice to kitchen-gce - I'll do that shortly, once I have time to do a little more than a smoke test with kitchen-google. I did notice that Travis needs some cleanup on Ruby 1.9, and the README could use a little cleanup too.

@erjohnso
Copy link

Awesome, thank you @anl!

@mbrukman
Copy link
Contributor

Thank you, @anl! 👍

@marcy-terui
Copy link

👍 👍 👍

@robbkidd
Copy link
Contributor

Reviewing issues, it looks like preemptible support is in the latest kitchen-google and this issue is still open to track the action of releasing one more kitchen-gce with a deprecation notice. Is that right?

@tas50
Copy link
Member

tas50 commented Nov 11, 2020

Closing this out since releasing a deprecation warning in kitchen-gce is outside the scope of this repo. We're now regularly releasing this gem and it ships in Chef Workstation.

@tas50 tas50 closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants