Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kitchen package work #275

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Make kitchen package work #275

merged 1 commit into from
Mar 24, 2017

Conversation

ccope
Copy link
Contributor

@ccope ccope commented Jan 6, 2017

Tested with the following config:

---
driver:
  name: vagrant
  provider: lxc

provisioner:
  name: chef_zero

platforms:
  - name: xenial64-lxc
    driver_plugin: vagrant
    driver_config:
      box: hrishikeshdate/xenial64
      ssh:
        insert_key: false

suites:
  - name: mysuite
    run_list:
      - recipe[mycookbook::default]

@cheeseplus
Copy link
Contributor

Looks like there are still some failures with the linting from the Travis build - also would love to get testing for the newly introduced command as well.

@cheeseplus cheeseplus modified the milestone: 0.21.2 Jan 8, 2017
@ccope
Copy link
Contributor Author

ccope commented Jan 9, 2017

Fixed the lint errors and squashed

mwrock
mwrock reviewed Jan 9, 2017
View reviewed changes
lib/kitchen/driver/vagrant.rb
instance.transport.connection(state).close
box_name = File.join(Dir.pwd, instance.name + ".box")
run("#{config[:vagrant_binary]} package --output #{box_name}")
destroy(state)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary/desirable to destroy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package command stops the machine, and I found testkitchen had trouble communicating with it if I re-ran vagrant up (ssh would keep failing). I'm not sure why.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok. Perhaps vagrant changes the state of the box. That's fair.

@n-rodriguez
Copy link

Hi! Would it be possible to customize the output filename in .kitchen.yml?

@n-rodriguez n-rodriguez mentioned this pull request Feb 6, 2017
Closed
@n-rodriguez
Copy link

Hi there! Any news?

@ccope
Copy link
Contributor Author

ccope commented Mar 23, 2017

I don't currently have the time to add more to this PR, but it seems like it would be a relatively easy change to make after it is merged.

@cheeseplus cheeseplus merged commit b9edd82 into test-kitchen:master Mar 24, 2017
@cheeseplus
Copy link
Contributor

Sorry this one was overlooked for so long, I thought we still had some questions to answer but this is safe enough and we can extend later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwrock mwrock mwrock approved these changes

Assignees
No one assigned
Labels
Feedback Requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccope @cheeseplus @n-rodriguez @mwrock