Fix #365 - add name for virtualbox instances #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seth Thomas <sthomas@chef.io>
tyler-ball
approved these changes
Aug 7, 2018
fretb
pushed a commit
to fretb/kitchen-vagrant
that referenced
this pull request
Apr 30, 2019
Fixes bug introduced by test-kitchen#366. By specifying a name in the Vagrantfile, we lose uniqueness added by the [Vagrant SetName class](https://github.com/hashicorp/vagrant/blob/85acf0cac724ef4bfda593a66e0c17f7e4110da0/plugins/providers/virtualbox/action/set_name.rb#L29). This PR restores uniqueness. Closes test-kitchen#376.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #365
This adds the
nameparameter for the VirtualBox provider configuration in the generated Vagrantfile. This only affects the UI and restores the old naming convention which make finding the VMs in the UI more convenient.Signed-off-by: Seth Thomas sthomas@chef.io