Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-kitchen should not use the color red for non-error information #97

Closed
jtimberman opened this issue May 5, 2013 · 3 comments
Closed

Test-kitchen should not use the color red for non-error information #97

jtimberman opened this issue May 5, 2013 · 3 comments
Milestone
1.0

Comments

@jtimberman
Copy link
Contributor

Occasionally test-kitchen will show me informational messages in red. Given the amount of output that test-kitchen produces by default and that I am often coming back to tests after letting them run for a while, the red text can be confusing.

Let's reserve red text for actual errors.

Cross posted from: http://tickets.opscode.com/browse/KITCHEN-73
@damm
Copy link

damm commented May 6, 2013

👍

@jtimberman
Copy link
Contributor Author

I think this is related to #96.

@fnichol
Copy link
Contributor

fnichol commented May 24, 2013

Ah I understand this now, no red for instance colors! Done.

fnichol added a commit that referenced this issue May 27, 2013
@fnichol
Remove bright_red as a candidate instance color.
2de3fd5 
References #97
thommay pushed a commit to thommay/test-kitchen that referenced this issue May 30, 2013
@fnichol
Remove red as a candidate instance color.
c2888a2 
This reserves the red color for errors and exceptions.

Closes test-kitchen#97
thommay pushed a commit to thommay/test-kitchen that referenced this issue May 30, 2013
@fnichol
Remove bright_red as a candidate instance color.
66ba944 
References test-kitchen#97
BrentOnRails pushed a commit to BrentOnRails/test-kitchen that referenced this issue Jul 17, 2017
@tyler-ball
Merge pull request test-kitchen#97 from test-kitchen/chuckg-feature/f…
9bd8e0f 
…ix_server_wait_for_private_ip_addresses

Fix connection to servers without a "public_ip_address" interface (ie: VPC)
@test-kitchen test-kitchen locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@damm @jtimberman @fnichol