Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codeclimate-test-reporter as that has been deprecated #1147

Merged
merged 1 commit into from Nov 9, 2016

Conversation

smurawski
Copy link
Contributor

Fixes the build for master.

Tracking bug to re-enable codeclimate reporting - #1146

Signed-off-by: Steven Murawski steven.murawski@gmail.com

Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
@smurawski smurawski merged commit f8f5a15 into master Nov 9, 2016
@smurawski smurawski deleted the smurawski/fix_build branch November 9, 2016 17:20
@coderanger
Copy link
Contributor

Just be clear, where are you seeing that this is deprecated? It changed with the 1.0 release but I don't see anything saying it is deprecated.

@smurawski
Copy link
Contributor Author

@coderanger the codeclimate-test-reporter as used by our build was deprecated and was breaking the build. there is another method to get the codeclimate results, and #1146 was filed to get that work done. https://travis-ci.org/test-kitchen/test-kitchen/jobs/174499510#L383

@coderanger
Copy link
Contributor

@smurawski https://github.com/codeclimate/ruby-test-reporter#upgrading-from-pre-10-versions you still need the gem, the part that needs to change is the build task and the spec helper.

@smurawski
Copy link
Contributor Author

@coderanger that's fine, but I didn't have the cycles to investigate the changes at the moment, so having build that wasn't breaking on an ancillary service is more important.

If you've got the cycles and want fix it up to re-enable, go for it. Otherwise, I'll dig in tomorrow.

@coderanger
Copy link
Contributor

Sure, no argument on removing it if no one has time right now. Just wanted to make sure I didn't miss anything because I use the same gem on some other projects (but with a semver pin so I'm not immediately affected by the breaking changes).

@test-kitchen test-kitchen locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants