Allow all plugins to toggle concurrency #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the four plugin types - driver, transport, provisioner, verifier - to declare that they are not thread safe on an action-by-action basis. Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
This was referenced Sep 2, 2020
tyler-ball
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, only Driver plugins were able to declare that they should not be run concurrently using
-c. In fact, individual plugins of other types may not be thread-safe, but they had no way of expressing this, and were thus run in parallel, sometimes to poor outcomes. This PR:no_parallel_forto be available to Transports, Provisioner, and Verifier plugins, as well as DriversThe minor version should be bumped when merging this PR.
Issues Resolved
Fixes #1677
Check List