Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gem runner install driver #416

Merged
merged 3 commits into from
Apr 24, 2014
Merged

Gem runner install driver #416

merged 3 commits into from
Apr 24, 2014

Conversation

mcquin
Copy link

@mcquin mcquin commented Apr 24, 2014

Fixes chef-boneyard/chef-dk#20. Makes driver gems install to the same ruby/gem installation as test-kitchen.

@schisamo
Copy link
Contributor

👍

sethvargo
sethvargo reviewed Apr 24, 2014
View reviewed changes
lib/kitchen/generator/init.rb
rescue Gem::SystemExitException => e
raise unless e.exit_code == 0
ensure
SafeYAML::OPTIONS[:default_mode] = :safe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment explaining why this is here/what it does/when it can be removed.

@danielsdeleo
Copy link
Contributor

According to #303 TK should be using require 'safe_yaml/load' to avoid 'safe_yaml's monkey patch, but TK requires 'safe_yaml' (w/ monkey patch) here:

test-kitchen/lib/kitchen/command/driver_discover.rb

Line 22 in 0ea7073

require 'safe_yaml'
Should it be doing that? /cc @fnichol

@sethvargo
Copy link
Contributor

Probably not. That might be legacy code?

@danielsdeleo
Copy link
Contributor

LGTM

sethvargo added a commit that referenced this pull request Apr 24, 2014
@sethvargo
Merge pull request #416 from mcquin/gem_runner-install-driver
9b232ea 
Gem runner install driver
@sethvargo sethvargo merged commit 9b232ea into test-kitchen:master Apr 24, 2014
fnichol added a commit that referenced this pull request Jul 21, 2014
@fnichol
Remove safe_yaml config & warnings in Generator::Init.
90c1254 
Blocking code in Command::DriverDiscover removed in
ff1fb8a

References #416
@test-kitchen test-kitchen locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to run kitchen init
4 participants
@mcquin @schisamo @danielsdeleo @sethvargo