chore: super simple verbose logs when pruning #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
requested review from
cristianrgreco,
eddumelendez,
HofmeisterAn and
kiview
HofmeisterAn
previously approved these changes
Apr 5, 2023
|
We decided to use env vars, only Explanation here: #49 (review) |
HofmeisterAn
reviewed
Apr 5, 2023
mdelapenya
commented
May 17, 2023
We only accept env vars for configuration
HofmeisterAn
approved these changes
May 17, 2023
eddumelendez
pushed a commit
to eddumelendez/moby-ryuk
that referenced
this pull request
Jul 10, 2023
* chore: super simple verbose logs when pruning * fix: indent * fix: indent after editing using the UI * chore: remove verbose flag We only accept env vars for configuration * docs: document the new environment variable * fix: remove outdated test * fix: remove outdated test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It supports configuring Ryuk to add verbosity when calling the Docker APIs. It can be set with the
RYUK_VERBOSEenvironment variable, which accepts boolean values.Everytime the Docker client is used to list/prune resources (containers, networks, volumes and images), a log will be produced if and only if the verbose variable is enabled.
Why is it important?
Support debugging certain failures while accessing the Docker engine