Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StartAsync cannot be canceled #335

Closed
HofmeisterAn opened this issue Oct 28, 2020 · 1 comment
Closed

StartAsync cannot be canceled #335

HofmeisterAn opened this issue Oct 28, 2020 · 1 comment
Assignees
@HofmeisterAn
Labels
enhancement New feature or request
Milestone
1.5.0

Comments

@HofmeisterAn
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The WaitStrategy in TestcontainersContainer.StartAsync cannot be canceled with the cancellation token.

Describe the solution you'd like
-

Describe alternatives you've considered
-

Additional context
-
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Oct 28, 2020
@HofmeisterAn HofmeisterAn added this to the 1.5.0 milestone Oct 28, 2020
@HofmeisterAn HofmeisterAn self-assigned this Oct 28, 2020
HofmeisterAn added a commit that referenced this issue Oct 28, 2020
@HofmeisterAn
[#335] #CHANGE 'assemblyName: DotNet.Testcontainers; function: Testco…
e697ee2 
…ntainersContainer'

{Add CancellationToken to StartAsync.}
HofmeisterAn added a commit that referenced this issue Oct 29, 2020
@HofmeisterAn
[#335] #CHANGE 'assemblyName: DotNet.Testcontainers; function: Testco…
5a394d0 
…ntainersContainer'

{Fix TestcontainersContainerCancellationTest and TestcontainersWaitStrategyTest.}
@HofmeisterAn
Copy link
Collaborator Author

PR #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HofmeisterAn HofmeisterAn

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
1 participant
@HofmeisterAn