-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy of tc-java#3893 #626
Comments
You can probably use the |
I don't think it would make sense to have the same configuration for two different things. Basically: new MySqlTestcontainerConfiguration {
Username = "standarduser",
Password = "standardpassword"
} should set: new MySqlTestcontainerConfiguration {
Username = "root",
Password = "rootpassword"
} should set: While still giving the right connectionString. |
I made a draft here #629 |
What I meant by that is, MySQL and MariaDB shares the same configuration. Right now, the configuration is copied and pasted. I think we can just inherit from one or the other and get rid of the copy and paste code. |
Describe the bug
The mysql container does not allow the username
root
for theMYSQL_USER
, which makes the current TestContainerConfiguration not useful as the container will fail to start.testcontainers-dotnet/src/Testcontainers/Configurations/Modules/Databases/MySqlTestcontainerConfiguration.cs
Lines 40 to 44 in 08e7fa5
To Reproduce
Expected behavior
Should incoporate the possibility to use
root
user (e.g. for migrations)Additional context
Basically a copy of testcontainers/testcontainers-java#3893 for dotnet.
The text was updated successfully, but these errors were encountered: