Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #626 #629

Merged
merged 7 commits into from
Oct 24, 2022
Merged

fix #626 #629

merged 7 commits into from
Oct 24, 2022

Conversation

DanielHabenicht
Copy link
Contributor

fix handling of "root" username for mysql container

@DanielHabenicht
Copy link
Contributor Author

error seems unrelated to my change?
Unrelated to that: Is there a way we could change the cake config, so one could build the nuget package locally too?

.WithCriteria(() => param.ShouldPublish)

@HofmeisterAn
Copy link
Collaborator

error seems unrelated to my change?

Yes, the error does not relate to your change. I addressed it to the dev that contributed Azurite. I will take a look at your changes in the next days.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to that: Is there a way we could change the cake config, so one could build the nuget package locally too?

Usually I set ShouldPublish to true:

ShouldPublish = !buildInformation.IsLocalBuild && buildInformation.ShouldPublish,

@vlaskal
Copy link
Contributor

vlaskal commented Oct 23, 2022

error seems unrelated to my change?

Yes, the error does not relate to your change. I addressed it to the dev that contributed Azurite. I will take a look at your changes in the next days.

@DanielHabenicht and @HofmeisterAn I created bug #631 to track the Azurite failure.

@DanielHabenicht
Copy link
Contributor Author

Unrelated to that: Is there a way we could change the cake config, so one could build the nuget package locally too?

Usually I set ShouldPublish to true:

Directly in the script? I thought there would be a Command Line Option for that, this way I always have to check what I commit :)

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please take a look at my recent comments and fix the code formatting in MySqlTestcontainerConfiguration? Then I am happy to merge it.

@HofmeisterAn
Copy link
Collaborator

Directly in the script? I thought there would be a Command Line Option for that, this way I always have to check what I commit :)

That is what I do. I ignore those changes with my global .gitignore, but OC we can add a mechanism to force skip the WithCriteria checks.

@DanielHabenicht DanielHabenicht marked this pull request as ready for review October 23, 2022 19:31
@HofmeisterAn HofmeisterAn merged commit d351697 into testcontainers:develop Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants