-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #626 #629
fix #626 #629
Conversation
src/Testcontainers/Containers/Modules/Databases/MySqlTestcontainer.cs
Outdated
Show resolved
Hide resolved
error seems unrelated to my change? testcontainers-dotnet/build.cake Line 133 in 08e7fa5
|
Yes, the error does not relate to your change. I addressed it to the dev that contributed Azurite. I will take a look at your changes in the next days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to that: Is there a way we could change the cake config, so one could build the nuget package locally too?
Usually I set ShouldPublish
to true:
ShouldPublish = !buildInformation.IsLocalBuild && buildInformation.ShouldPublish, |
src/Testcontainers/Configurations/Modules/Databases/MySqlTestcontainerConfiguration.cs
Outdated
Show resolved
Hide resolved
@DanielHabenicht and @HofmeisterAn I created bug #631 to track the Azurite failure. |
Directly in the script? I thought there would be a Command Line Option for that, this way I always have to check what I commit :) |
to not make them dependent on the username being set first
95f60b7
to
cb89ffe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please take a look at my recent comments and fix the code formatting in MySqlTestcontainerConfiguration
? Then I am happy to merge it.
src/Testcontainers/Configurations/Modules/Databases/MySqlTestcontainerConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Testcontainers/Configurations/Modules/Databases/MySqlTestcontainerConfiguration.cs
Outdated
Show resolved
Hide resolved
...tcontainers.Tests/Unit/Containers/Unix/Modules/Databases/MySqlTestcontainerNormalUserTest.cs
Outdated
Show resolved
Hide resolved
This reverts commit 52ef3dc.
That is what I do. I ignore those changes with my global |
fix handling of "root" username for mysql container