Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Elasticsearch example #1010

Merged

Conversation

khalidabuhakmeh
Copy link
Contributor

What does this PR do?

Adds an example for Elasticsearch, which also tells developers about that certificate issue they need to work around. :)

Why is it important?

For completeness

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit f110b99
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/651bc2e3f5ab4a0008ba28b9
😎 Deploy Preview https://deploy-preview-1010--testcontainers-dotnet.netlify.app/modules/elasticsearch
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

HofmeisterAn
HofmeisterAn previously approved these changes Oct 3, 2023
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🍂. I applied some minor changes to keep both examples more consistent.

docs/modules/elasticsearch.md Outdated Show resolved Hide resolved
docs/modules/elasticsearch.md Outdated Show resolved Hide resolved
docs/modules/elasticsearch.md Outdated Show resolved Hide resolved
@HofmeisterAn HofmeisterAn added the documentation Docs, docs, docs. label Oct 3, 2023
@HofmeisterAn HofmeisterAn changed the title Add Elasticsearch example to docs. docs: Add Elasticsearch example Oct 3, 2023
@HofmeisterAn HofmeisterAn merged commit 86b8258 into testcontainers:develop Oct 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants