Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added WithBuildArgument method to ImageFromDockerfileBuilder #510

Closed
wants to merge 2 commits into from
Closed

Added WithBuildArgument method to ImageFromDockerfileBuilder #510

wants to merge 2 commits into from

Conversation

michal-korniak
Copy link

@michal-korniak michal-korniak commented Jul 11, 2022 •
edited
Loading

Some images requires arguments for build process. This PR enable to use this option with the framework.

HofmeisterAn
HofmeisterAn reviewed Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request 🙏. Do you think we can cover it via a unit test?

@michal-korniak
Copy link
Author

I don't know how to test it. Remember that these kind of variables are present only during build time.

HofmeisterAn
HofmeisterAn approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to test it. Remember that these kind of variables are present only during build time.

Yeah, I couldn't think of anything either.

HofmeisterAn
HofmeisterAn reviewed Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take a look at the tests?

HofmeisterAn
HofmeisterAn approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I’ll merge it tomorrow.

@HofmeisterAn
Copy link
Collaborator

Thanks again for your work 39671c0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HofmeisterAn HofmeisterAn HofmeisterAn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michal-korniak @HofmeisterAn @michal-korniak-kornit