Fix ExecScriptAsync on MongoDbTestcontainer #565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| await this.CopyFileAsync(tempScriptFile, Encoding.Default.GetBytes(script), 493, 0, 0, ct) | ||
| .ConfigureAwait(false); | ||
|
|
||
| return await this.ExecAsync(new[] { "mongo", "db", tempScriptFile }, ct); |
There was a problem hiding this comment.
Can't we just use the new MongoDB Shell (mongosh) and remove ExecMongoScriptAsync?
There was a problem hiding this comment.
Absolutely. This was just in case there was a desire to support the legacy shell while it is still available. Will remove, thanks.
| await this.CopyFileAsync(tempScriptFile, Encoding.Default.GetBytes(scriptContent), 493, 0, 0, ct) | ||
| .ConfigureAwait(false); | ||
|
|
||
| return await this.ExecAsync(new[] { "mongosh", "--port", this.ContainerPort.ToString(CultureInfo.InvariantCulture), "--eval", $"load('{tempScriptFile}')" }, ct) |
There was a problem hiding this comment.
Can we pass the ConnectionString to mongosh (at least username and password)?
There was a problem hiding this comment.
Agreed but will need to look into this one. After supplying the credentials to the mongosh I'm able to connect however my user did not have permissions to run scripts it seems. Will need to look into setting up that user before hand when usr/pwd are configured with the container builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDbTestcontainer ExecScriptAsync should execute mongosh scripts