chore: Replace host port 0 with an empty string #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HofmeisterAn
added
the
chore
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kiview
reviewed
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the default host port from
0to an empty string. Considering docker/for-mac#5588 (comment) the implementation of Docker Desktop behaves different. We see this in the chosen ports too. The port ranges are different. This is just the preparation. If there are no issues we can removeResourceReaperPublicHostPortand the host port0configurations from the modules.Why is it important?
To align with the Java implementation. All TC developers should experience the same behavior.
Related issues
TESTCONTAINERS_HOST_OVERRIDEfor DinD on Docker Desktop testcontainers-java#6383 (review)