Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to fix flakyness in genserver start (or at least find culprit) #67

Merged
merged 1 commit into from
Dec 25, 2023
Merged

try to fix flakyness in genserver start (or at least find culprit) #67

merged 1 commit into from
Dec 25, 2023

Conversation

jarlah
Copy link
Member

@jarlah jarlah commented Dec 25, 2023

fixes #61

@jarlah jarlah changed the title try to fix flakyness in genserver start try to fix flakyness in genserver start (or at least find culprit) Dec 25, 2023
@jarlah jarlah merged commit ea177b8 into main Dec 25, 2023
5 checks passed
@jarlah jarlah deleted the fixFlakyTest branch December 25, 2023 11:05
@Argonus
Copy link
Contributor

Argonus commented Jan 8, 2024

@jarlah Still this flake test fails sometimes, but even running it with proper seed does gives 100% change it will fail.
I'll try to take a look at it, as it's more common once I've added multi versions support, do you have any clues?

@jarlah
Copy link
Member Author

jarlah commented Jan 8, 2024

seems to be some wierdness with the socket creation, timeouts or something. We should maybe retry creating the socket to ryuk at least a couple of times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix awfully flaky tests
2 participants
@jarlah @Argonus