avoid race conditions by waiting one polling interval before checking…

… ports are bound (#1697)

wait/http.go

@@ -146,8 +146,10 @@ func (ws *HTTPStrategy) WaitUntilReady(ctx context.Context, target StrategyTarge
 
 	var mappedPort nat.Port
 	if ws.Port == "" {
-		ports, err := target.Ports(ctx)
-		for err != nil {
+		var err error
+		var ports nat.PortMap
+		// we wait one polling interval before we grab the ports otherwise they might not be bound yet on startup
+		for err != nil || ports == nil {
 			select {
 			case <-ctx.Done():
 				return fmt.Errorf("%w: %w", ctx.Err(), err)

wait/http_test.go

@@ -562,7 +562,8 @@ func TestHttpStrategyFailsWhileGettingPortDueToNoExposedPorts(t *testing.T) {
 		},
 		StateImpl: func(_ context.Context) (*types.ContainerState, error) {
 			return &types.ContainerState{
-				Status: "running",
+				Status:  "running",
+				Running: true,
 			}, nil
 		},
 		PortsImpl: func(ctx context.Context) (nat.PortMap, error) {
@@ -602,7 +603,8 @@ func TestHttpStrategyFailsWhileGettingPortDueToOnlyUDPPorts(t *testing.T) {
 		},
 		StateImpl: func(_ context.Context) (*types.ContainerState, error) {
 			return &types.ContainerState{
-				Status: "running",
+				Running: true,
+				Status:  "running",
 			}, nil
 		},
 		PortsImpl: func(ctx context.Context) (nat.PortMap, error) {
@@ -649,7 +651,8 @@ func TestHttpStrategyFailsWhileGettingPortDueToExposedPortNoBindings(t *testing.
 		},
 		StateImpl: func(_ context.Context) (*types.ContainerState, error) {
 			return &types.ContainerState{
-				Status: "running",
+				Running: true,
+				Status:  "running",
 			}, nil
 		},
 		PortsImpl: func(ctx context.Context) (nat.PortMap, error) {