New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go fmt is not failing Travis build #124
Comments
mdelapenya
referenced
this issue
in mdelapenya/testcontainers-go
Dec 26, 2019
Merged
I agree with this, the builds should fail if |
mdelapenya
referenced
this issue
in mdelapenya/testcontainers-go
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running
go fmt ./...
with current master (https://github.com/testcontainers/testcontainers-go/tree/0c6fcb48ff1cfa4d82a45b587e76b3588a4dc192) discovers a formatting problem in thedocker_test.go
file.I wonder if the Travis build should be failed in that case 🤔 I think so, as Go is very opinionated when talking about source code format.
To check that Travis is showing same information: https://travis-ci.org/testcontainers/testcontainers-go/builds/629696018#L370-L371
Thoughts?
The text was updated successfully, but these errors were encountered: