Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go fmt is not failing Travis build #124

Closed
mdelapenya opened this issue Dec 26, 2019 · 2 comments · Fixed by #125
Closed

Go fmt is not failing Travis build #124

mdelapenya opened this issue Dec 26, 2019 · 2 comments · Fixed by #125

Comments

@mdelapenya
Copy link
Collaborator

mdelapenya commented Dec 26, 2019

Running go fmt ./... with current master (https://github.com/testcontainers/testcontainers-go/tree/0c6fcb48ff1cfa4d82a45b587e76b3588a4dc192) discovers a formatting problem in the docker_test.go file.

$  testcontainers-go git:(master) ✗ go fmt ./...   
docker_test.go
$  testcontainers-go git:(master) ✗ git diff docker_test.go 
──────────────────────────────────────────────────────────────────────────────────────────────────────────
 modified: docker_test.go
──────────────────────────────────────────────────────────────────────────────────────────────────────────
@ docker_test.go:928 @ func TestContainerCreationWithBindAndVolume(t *testing.T) {
            BindMounts:   map[string]string{absPath: "/hello.sh"},
            VolumeMounts: map[string]string{volumeName: "/data"},
            Cmd:          []string{"bash", "/hello.sh"},
-            WaitingFor: wait.ForLog("done"),
+            WaitingFor:   wait.ForLog("done"),
        },
        Started: true,
    })

I wonder if the Travis build should be failed in that case 🤔 I think so, as Go is very opinionated when talking about source code format.

To check that Travis is showing same information: https://travis-ci.org/testcontainers/testcontainers-go/builds/629696018#L370-L371

Thoughts?

mdelapenya referenced this issue in mdelapenya/testcontainers-go Dec 26, 2019
@ClaytonNorthey92
Copy link
Contributor

I agree with this, the builds should fail if go fmt was not run on the files

mdelapenya referenced this issue in mdelapenya/testcontainers-go Dec 27, 2019
gianarb added a commit that referenced this issue Dec 30, 2019
@mdelapenya
Copy link
Collaborator Author

Fixed!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants