(#124) Fix Go fmt #125
Merged
(#124) Fix Go fmt #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaytonNorthey92
approved these changes
Dec 26, 2019
|
Last commit is a cherry pick from #97 |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes the format of one file, discovered while running Travis commands locally,
but it's possible to find the errors there too:
https://travis-ci.org/testcontainers/testcontainers-go/builds/629696018#L370-L371
At the same time, it adds a shell script that raises the error level after a failure in the
go fmtcommand. Please check this thread for more info about this issue: golang/go#24230Why is it important?
It fixes the CI build, which is currently not failing, but IMHO it should. Besides that it will cause the build to fail if a P is sent without the proper Go format being applied.
Related issues
Closes #124